Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix freezes for QZXing on Android with Qt 6.5 #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix freezes for QZXing on Android with Qt 6.5 #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/QZXingFilterVideoSink.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ void QZXingFilter::setVideoSink(QObject *videoSink){
}

void QZXingFilter::processFrame(const QVideoFrame &frame) {
#ifdef Q_OS_ANDROID
#if defined Q_OS_ANDROID && QT_VERSION < QT_VERSION_CHECK(6, 5, 0)
m_videoSink->setRhi(nullptr); // https://bugreports.qt.io/browse/QTBUG-97789
QVideoFrame f(frame);
f.map(QVideoFrame::ReadOnly);
Expand Down Expand Up @@ -108,7 +108,7 @@ void QZXingFilter::processFrame(const QVideoFrame &frame) {
});
}

#ifdef Q_OS_ANDROID
#if defined Q_OS_ANDROID && QT_VERSION < QT_VERSION_CHECK(6, 5, 0)
f.unmap();
#endif
}