Revert auto_mkdir default in open() and special case local #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindurant
commented
Sep 18, 2023
| @@ -284,6 +288,11 @@ def open_files( | |||
| protocol=protocol, | |||
| expand=expand, | |||
| ) | |||
| if fs.protocol == "file": | |||
| fs.auto_mkdir = auto_mkdir | |||
There was a problem hiding this comment.
I do not see an easier way to do this than this fragile line, because the creation of the fs is hidden within the unchaining logic inside the call above.
joverlee521
added a commit
to nextstrain/cli
that referenced
this pull request
Sep 18, 2023
Changes to the `auto_mkdir` parameter in fsspec/filesystem_spec#1358 leads to the error described in fsspec/s3fs#790. Upstream fixes to come soon via fsspec/filesystem_spec#1365 but good to avoid versions that we know are broken.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fsspec/s3fs#790
Fixes dask/dask#10515