Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(charts/strichlistensystem): add chart, feat(charts/portals): add new env vars #16

Merged
merged 7 commits into from
Oct 30, 2023
Merged

feat(charts/strichlistensystem): add chart, feat(charts/portals): add new env vars #16

merged 7 commits into from
Oct 30, 2023

Conversation

simonostendorf
Copy link
Contributor

Closes #15

@simonostendorf simonostendorf added enhancement New feature or request chart: strichlistensystem Issues or pull requests that target the "strichlistensystem" chart. labels Oct 16, 2023
@simonostendorf simonostendorf self-assigned this Oct 16, 2023
@simonostendorf
Copy link
Contributor Author

Wait for fsr5-fhaachen/strichlistensystem#29 to implement the new importer and include the needed files in the seed-job here.

@simonostendorf

This comment was marked as resolved.

Sign in to view
@simonostendorf
Copy link
Contributor Author

Remember to add VPN

See fsr5-fhaachen/strichlistensystem#76

@simonostendorf
Copy link
Contributor Author

Adjust env vars:

APP_VPN_IP (remove)
APP_IS_VPN=false
APP_PORTALS_URL=http://127.0.0.1:8000
APP_PORTALS_API_SECRET=secret
APP_PORTALS_IMPORT_PW=123

@simonostendorf simonostendorf linked an issue Oct 20, 2023 that may be closed by this pull request
adjust chart for portals release 2.3.0 #17
Closed
3 tasks
@simonostendorf simonostendorf changed the title feat(charts/strichlistensystem): add chart feat(charts/strichlistensystem): add chart, feat(charts/portals): add new env vars Oct 24, 2023
@simonostendorf simonostendorf added the chart: portals Issues or pull requests that target the "portals" chart. label Oct 24, 2023
@simonostendorf simonostendorf marked this pull request as ready for review October 25, 2023 06:28
TitusKirch
TitusKirch previously approved these changes Oct 25, 2023
View reviewed changes
@TitusKirch TitusKirch merged commit 932e5c7 into main Oct 30, 2023
1 check passed
@TitusKirch TitusKirch deleted the feat/charts/strichlistensystem branch October 30, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TitusKirch TitusKirch TitusKirch approved these changes

@PhilPinsdorf PhilPinsdorf Awaiting requested review from PhilPinsdorf

@tijavo tijavo Awaiting requested review from tijavo

@DontEdit DontEdit Awaiting requested review from DontEdit

Assignees

@simonostendorf simonostendorf

Labels
chart: portals Issues or pull requests that target the "portals" chart. chart: strichlistensystem Issues or pull requests that target the "strichlistensystem" chart. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adjust chart for portals release 2.3.0 add chart for "strichlistensystem"
2 participants
@simonostendorf @TitusKirch