Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET & FSharp.Core Version #4272

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

1eyewonder
Copy link

Wanted to try to take a whack at this one which was mentioned in the Discord channel. I went ahead and updated the net core version up to 8 as well as updated FSharp.Core. I'm hoping this takes a bite of the elephant so I can go ahead and attempt at getting #4250 back on track

@1eyewonder
Copy link
Author

@forki I have a question on the ci/cd pipeline. I was looking through recent PRs which were merged and it looks like the tests were cancelled. I however have running tests with some failures. Should I treat this as I need to do more updates to get the tests passing or is this a separate issue related to the tests? I just want to make sure I'm not introducing any errors with these changes 😄

@Numpsy
Copy link

Numpsy commented Sep 6, 2024

Looks to me like some of the those tests are already failing in cases where the pipeline doesn't hang/timeout - https://ci.appveyor.com/project/paket/paket/builds/50550293 (#4273 )

@Numpsy
Copy link

Numpsy commented Sep 11, 2024

Anyway, it looks to me like the fcs can type check test is hanging with an error of the sort described in #4102 and this PR and the Chessie one both unstick it somehow (updated or removed dependencies I guess)

Removing some old deps in #4273 also unstuck it, though the test then failed in .NET Core (actually, I'm not sure what the direct Microsoft.Win32.Registry dependency is for - I don't immediately see any Registry access in the project)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants