Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Don't Merge Yet] Fix #3906: missing url escape of square backets #3908

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Don't Merge Yet] Fix #3906: missing url escape of square backets #3908

wants to merge 1 commit into from

Commits on Sep 14, 2020

  1. Fix fsprojects#3906: missing url escape of square backets 

    As System.Uri.GetComponents(...*UriFormat.SafeUnescaped*) is based on
the outdated RFC 2396 it unescapes angle brackets, which usage is only
declared "unwise" in the original URI RFC from 1998. The uptodate one,
RFC 3986, forbidds them in path segments. This causes trouble with
software based on the newer RFC, such as the OPC API in
`System.IO.Packaing`.

Instead of hooking a third layer of escape/unescape layer on top of the
existing code, I decided to rewrite the `ensureValidName` method, hoping
the intend of the code is clearer now. For more details see the comments
in fsprojects#3906.
    @jbaehr
    jbaehr committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    cfbe809 View commit details
    Browse the repository at this point in the history