Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] #1857 Warning for FSharp.Core without forced redirects #3382

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chrnola
Copy link
Contributor

@chrnola chrnola commented Oct 9, 2018

Hi there,

First time contributor here just looking for feedback about how to implement this. The two commits included show my two proposed approaches. The first involves iterating over the entire model, while the second is done from within the model creation function (and includes some minor unrelated cleanup). If there's a better place for this logic, please let me know.

Also, how do we feel about the warning text? I included the text from #1857, but I'm open to changing it.

Once I get answers to these I'll work on adding test coverage and then submit a cleaner PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant