Ability to add errors to resolved fields #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covered test case: Add additional error and return value from a non-nullable GraphQL field resolver
…ers`/`resolveWith`
VectorTetra
force-pushed
the
add-errors-to-resolved-fields
branch
from
6ce4185 to
8c5a23c
Compare
xperiandri
approved these changes
Feb 4, 2025
ePasha
reviewed
Feb 4, 2025
| match ctx.Context.Errors.TryGetValue ctx with | ||
| | true, errors -> | ||
| errors | ||
| |> Seq.map (GQLProblemDetails.OfFieldExecutionError (path |> List.rev)) |
There was a problem hiding this comment.
You either do List.rev inside function OfFieldExecutionError or at least create function normalizedPath() = path |> List.rev somewhere
xperiandri
requested changes
Feb 4, 2025
Comment on lines
118
to
123
| let internal normalizedPath(fieldPath : FieldPath) = | ||
| fieldPath |> List.rev | ||
|
|
||
| let internal normalizedPathToObj(fieldPath : FieldPath) = | ||
| fieldPath |> List.rev |> box | ||
|
|
There was a problem hiding this comment.
Suggested change
| let internal normalizedPath(fieldPath : FieldPath) = | |
| fieldPath |> List.rev | |
| let internal normalizedPathToObj(fieldPath : FieldPath) = | |
| fieldPath |> List.rev |> box | |
| let internal normalizeErrorPath (fieldPath : FieldPath) = | |
| fieldPath |> List.rev | |
There was a problem hiding this comment.
Should I remove normalizedPathToObj function?
xperiandri
reviewed
Feb 5, 2025
xperiandri
reviewed
Feb 5, 2025
xperiandri
approved these changes
Feb 5, 2025
xperiandri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago @xperiandri removed this functionality as exceptions were no longer processed anywhere.
Now I add it back aligned to the new
Resultbased internal resolvers execution