Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update toolbar to match Symfony 7 #72

Merged
merged 9 commits into from
Dec 13, 2023
Merged

Update toolbar to match Symfony 7 #72

merged 9 commits into from
Dec 13, 2023

Conversation

barryvdh
Copy link
Member

So it does not change that much, but Javascript etc is updated. Basic functions work, but need to check:

  • profileUrl should be passed / is changed?
  • What does Symfony-Debug-Toolbar-Replace do? Do we need it?
  • re-open button is not visible anymore
  • update light theme and customisations?

@barryvdh barryvdh marked this pull request as draft December 13, 2023 10:15
@barryvdh
Copy link
Member Author

Okay the Replace header now defines if the content is auto-replaced. I've made this a config option and removed the toggle button (and renamed it x-debug-toolbar-replace)
Also restored the click-to-load profile instead of opening the Telescope page directly.

@barryvdh
Copy link
Member Author

Seems to be working now
image

@barryvdh barryvdh marked this pull request as ready for review December 13, 2023 11:03
@barryvdh
Copy link
Member Author

New icons from https://tabler.io/icons
image

@barryvdh barryvdh merged commit c39aa3a into master Dec 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@barryvdh