Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move assets out of top-level to prevent conflicts #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move assets out of top-level to prevent conflicts #55

wants to merge 1 commit into from

Conversation

boatrite
Copy link

I ran into a problem when including wysiwyg-rails into our project.
After adding the gem to our Gemfile and attempting to load a page, we
were getting an error about an undefined sass variable.

The problem is that wysiwyg-rails adds themes/*.css to the asset
precompilation array and our project also has a themes directory. But
unlike froala's themes directory ours has partials that can't be
compiled by themselves, so we'd get a sass error when trying to view any
page.

Unfortunately, this is a breaking change. Not sure if there's a better way to go about this. Feedback very much welcome.

Cheers

I ran into a problem when including wysiwyg-rails into our project.
After adding the gem to our Gemfile and attempting to load a page, we
were getting an error about an undefined sass variable.

The problem is that wysiwyg-rails adds themes/*.css to the asset
precompilation array and our project also has a themes directory. But
unlike froala's themes directory ours has partials that can't be
compiled by themselves, so we'd get a sass error when trying to view any
page.
@stefanneculai
Copy link
Contributor

It's a good change, however, that would break all the current implementations. We might consider adding it in 2.9.0 release. Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants