Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puppeteerArgs type in README.md #212

Closed
wants to merge 1 commit into from

Conversation

Steve0929
Copy link

@Steve0929 Steve0929 commented Sep 20, 2023

Fixed puppeteerArgs type, it should be an array of strings as per puppeteer also added usage example.

Fixed puppeteerArgs type and added example
@frinyvonnick
Copy link
Owner

Hi @Steve0929 👋

puppeteerArgs is the whole object passed to the launch function and not only the args passed to Chromium. So it is object but maybe the description of the property is misguiding 🤔 How could we improve it?

@Steve0929
Copy link
Author

Ohh you are right, I think my confussion came from the naming, maybe using the same name: puppeteerOptions that is passed to Cluster.launch instead of puppeteerArgs could be clearer 🤔. I think we can close this for now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants