Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to ESM #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Convert to ESM #60

wants to merge 1 commit into from

Conversation

hsorbo
Copy link
Member

@hsorbo hsorbo commented Aug 9, 2024

No description provided.

@oriori1703
Copy link

oriori1703 commented Feb 9, 2025

Hi @hsorbo ,

I have reviewed the code and everything seems correct (except from the small comments I left).
Was there anything else that is missing from this PR, or is it a draft because it is blocked on gumJS?

I'm asking because I'm trying to revive the PRs to add support for ESM in gumJS (which includes this PR).
I'm pretty much done with the java-bridge, and swift-bridge and I'm only missing the code in gumJs itself.

So let me know if I can help in any way 😄

@hsorbo
Copy link
Member Author

hsorbo commented Feb 10, 2025

Hi @hsorbo ,

I have reviewed the code and everything seems correct (except from the small comments I left). Was there anything else that is missing from this PR, or is it a draft because it is blocked on gumJS?

I'm asking because I'm trying to revive the PRs to add support for ESM in gumJS (which includes this PR). I'm pretty much done with the java-bridge, and swift-bridge and I'm only missing the code in gumJs itself.

So let me know if I can help in any way 😄

Current plan is to move bridges out of gumjs and let them live as normal dependencies in agents. This will be a breaking change so it's targeted for next major. (some issues around java bridge needs to be ironed out for this and also bundling bridges in frida-tools).

Im changing from draft, but it's not gonna merge before refactoring bridges out of gumjs

@hsorbo hsorbo marked this pull request as ready for review February 10, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants