linux: Allocate stack for injector's remote calls #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oleavr I'm sure you'll have style comments and suggestions. I'd like to learn the right way to do things so I can more effectively help myself in the future. Let me know what you think of this when you find the time. Thanks! |
|
Okay, this patch relied on #550 to rebuild the bootstrapper images. I got rid of the build flags to enable this functionality from the original draft. I think this is a reasonable default. |
oleavr
force-pushed
the
add-stack
branch
2 times, most recently
from
1e43af9
to
5e28fbe
Compare
For some target programs it's not reasonable to assume that any hijacked thread has a large stack. For example, in Go, stacks are often small and are allocated on the heap. The injector bootstrap program uses kilobytes of stack. In order to side-step this problem, this patch changes the boostrapper to allocate an auxiliary stack for remote calls to use and, for the bootstrapper and loader, uses it. The calls to mmap and munmap don't use much stack, so they are fine. Fixes frida#544.
oleavr
changed the title
|
Thanks! 🙌 Sorry it took me so long to get to this. Figured I'd make the final tweaks myself to not bother you with super-late feedback 😅 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some target programs it's not reasonable to assume that any hijacked thread has a large stack. For example, in Go, stacks are often small and are allocated on the heap. The injector bootstrap program uses kilobytes of stack. In order to side-step this problem, this patch enables an option to allocate an auxiliary stack for the remote call to use and, for the bootstrapper and loader, uses it.
The calls to mmap and munmap don't use much stack, so they are fine.
Fixes #544