-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Data Package compatibility to vignettes #246
Conversation
@sannegovaert could you already review the Data Resource and Table Dialect vignettes? You can see them locally by running |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 626 626
=========================================
Hits 626 626 ☔ View full report in Codecov by Sentry. |
This removes "Standard implementation" from navbar, but provides a better articles/index.html page to link to
@sannegovaert this PR is now ready for review:
As before, you can build the site locally with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only have some small suggestions.
@sannegovaert changes made, please see the 3 open conversations if you agree. |
All good! |
Fix #208
example_package
#114)