SVG Import Changes/Fixes #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we parse colors properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes needs testing to confirm that I didn't break anything. Everything looks good on my end, but I can't test everything.
So, what does these changes do?
I was browsing Inkscape issues yesterday and came across this issue: https://gitlab.com/inkscape/inbox/-/issues/11086
Just out of curiosity I tested this in Friction, and we have the same issues.
So I fixed it.
We now handle RGB/RGBA INT/DOUBLE/PERCENT color values properly and read the
stroke-widthattribute (percent not supported yet).