SVG Mask: don't allow spaces in item id

friction2d · Aug 22, 2024 · f255351 · f255351
1 parent 83feac6
commit f255351
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/core/Boxes/boundingbox.cpp b/src/core/Boxes/boundingbox.cpp
@@ -1367,7 +1367,7 @@ eTask* BoundingBox::saveSVGWithTransform(SvgExporter& exp,
 
             if (maskId == ptr->prp_getName()) { // move mask to defs
                 auto& eleMask = taskPtr->initialize("mask");
-                eleMask.setAttribute("id", ptr->prp_getName());
+                eleMask.setAttribute("id", QString(ptr->prp_getName()).simplified().replace(" ", ""));
                 eleMask.appendChild(withEffects);
                 expPtr->addToDefs(eleMask);
             } else {

diff --git a/src/core/Boxes/containerbox.cpp b/src/core/Boxes/containerbox.cpp
@@ -200,7 +200,7 @@ class GroupSaverSVG : public ComplexTask
                 }
             }
             if (!mItemMaskId.isEmpty()) {
-                mEle.setAttribute("mask", QString("url(#%1)").arg(mItemMaskId));
+                mEle.setAttribute("mask", QString("url(#%1)").arg(QString(mItemMaskId).simplified().replace(" ", "")));
             }
         }
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -200,7 +200,7 @@ class GroupSaverSVG : public ComplexTask @@
                     }
                 }
                 if (!mItemMaskId.isEmpty()) {
-                    mEle.setAttribute("mask", QString("url(#%1)").arg(mItemMaskId));
+                    mEle.setAttribute("mask", QString("url(#%1)").arg(QString(mItemMaskId).simplified().replace(" ", "")));
                 }
             }
         }
@@ Expand Down @@