This repository was archived by the owner on Jan 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
using standard python base image #74
Open
yifanfu
wants to merge
1
commit into
freyta:master
Choose a base branch
from
yifanfu:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to work fine on my side. Can anyone else confirms that it doesn't work?
|
@freyta I'm also finding the Alpine image builds fine. The proposed changes in this PR would dramatically increase the image size. It also fails to link to a specific version of the python base image, which is against Dockerfile best practices as it would make the 7Eleven-Python image susceptible to future changes in the base image that may break it. @yifanfu Could you please share some more information about what issue you're having with the cryptography build using the Alpine base image? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the cryptography seems failed to build in apline version of python base image. I have replaced the alpine version of python with the standard (I believe it's Debian based) version of python base image, and all the builds passed.