Bug Fix (#882) Use correct feature flags with srtool #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled debug logging in srtool for easier checking
saraswatpuneet
approved these changes
Jan 7, 2023
demisx
approved these changes
Jan 7, 2023
demisx
reviewed
Jan 7, 2023
This really is just a check on srtool not our code, so it is release oriented only. None of our code /should/ impact this. Also keeping an eye on chevdor/srtool-cli#7 to see if we can use something simpler when it is out. |
abadaa
pushed a commit
that referenced
this pull request
Jan 10, 2023
# Goal The goal of this PR is to make sure that the correct feature flags are being used with srtool for wasm generation Closes #882 # Discussion - srtool default-features flag does not work as intended - Instead using build-opts - Enabled debug logging in srtool for easier checking - Added subwasm check to test the output wasm Test Runs: - Mainnet: https://github.com/LibertyDSNP/frequency/actions/runs/3859784794/jobs/6579633360 <img width="1010" alt="image" src="https://user-images.githubusercontent.com/1252199/211126355-d6f917d3-0ef2-447c-8f81-ac5333ce34d1.png"> - Rococo: https://github.com/LibertyDSNP/frequency/actions/runs/3859784794/jobs/6579633325 <img width="892" alt="image" src="https://user-images.githubusercontent.com/1252199/211126378-037467be-b34d-4e6c-bafb-effdafb46328.png"> # Checklist - [x] Tests added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to make sure that the correct feature flags are being used with srtool for wasm generation
Closes #882
Discussion
Test Runs:
Mainnet: https://github.com/LibertyDSNP/frequency/actions/runs/3859784794/jobs/6579633360
Rococo: https://github.com/LibertyDSNP/frequency/actions/runs/3859784794/jobs/6579633325
Checklist