-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support events watching from specific contracts #14
base: main
Are you sure you want to change the base?
[WIP] Support events watching from specific contracts #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good @AwaitFuture 🦸
Testing is definitely lacking across the project and now that there are 2 of us I'll start adding them. A config parser test seems fine for now as there isn't any kind of reasonable test structure for you to add onto atm.
3dd6ce6
to
15f4a22
Compare
a68107d
to
be54b53
Compare
It seems like theres some transient failures on some tests; running individual tests seems to fail locally, but running all tests together causes them to pass most of the time. I looked through for a bit to see if I could sus out what is persisting from some test that allows all the others to pass, but Im not really sure. |
Thanks for the updates @AwaitFuture. I'll have to take a look at it locally |
be54b53
to
6f88c55
Compare
@rupurt I set the test blockchain in the runtime config to launch on start; somehow the poll interval for new heads gets set to nil if you do this sometimes. reverting that fixed it. |
Problem:
Solution:
should solve most of #4
Open questions: