Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using Mergeable; Replace with own native check #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yowmamasita
Copy link
Contributor

@yowmamasita yowmamasita commented Nov 30, 2023

https://forto.atlassian.net/browse/ENGG-123

Because Mergeable is not working or slow at times

Why would a regex check take more than a minute finish execution?

Regex tested on all existing JIRA projects (183 projects in total)

Test it on itself

Symlinks dont work

Remove symlink

Debug description

Use perl because we need the negative lookbehind

Revise regex regexr.com/7o5js

Slurp the whole description
@yowmamasita yowmamasita marked this pull request as ready for review November 30, 2023 11:38
@yowmamasita yowmamasita changed the title Replace with own native check Stop using Mergeable; Replace with own native check Dec 12, 2023
Copy link
Contributor Author

@yowmamasita yowmamasita Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only used to test itself

Copy link
Member

@danopia danopia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to see this happen

Would mergeable still try running on every PR without the config file?

@yowmamasita
Copy link
Contributor Author

Would mergeable still try running on every PR without the config file?

I think this was the only config enabling Mergeable to lay its waste

@yowmamasita
Copy link
Contributor Author

What would it take to merge this? Or should we keep Mergeable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants