Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for multiple prefixes and related fixes #116

Merged
merged 17 commits into from
Nov 27, 2023

Conversation

istrator2
Copy link
Contributor

  • I add support for multiple prefixes. Unique domains have to be used after the prefix.
  • I fixed minor typos.
  • My IDE did a lot of autoformatting.

I have no idea about docker, yml and other non python files, please double check them.
Maybe, more likely, something is missing.

Copy link
Member

@krombel krombel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but I could not find issues through inspection.
LGTM

Copy link
Member

@krombel krombel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix errors

.github/buildkitd.toml Outdated Show resolved Hide resolved
@istrator2 istrator2 changed the title Feature/ffwert support for multiple prefixes and related fixes Nov 27, 2023
@istrator2 istrator2 marked this pull request as ready for review November 27, 2023 21:25
@istrator2
Copy link
Contributor Author

@krombel @grische: I fixed everything you asked for.

@grische grische enabled auto-merge (squash) November 27, 2023 21:28
@grische grische merged commit eab4be0 into freifunkMUC:main Nov 27, 2023
4 of 5 checks passed
@istrator2 istrator2 deleted the feature/ffwert branch November 27, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants