Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramips-mt7620: Add support for Netgear EX6120 #3420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fabianh95
Copy link
Contributor

  • Must be flashable from vendor firmware
    • Web interface
    • TFTP
    • nmrpflash
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())')
      -> netgear-ex6120
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging)
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages) -> MAC-Address match eth0 and br-wan but not br-client (last digit changed)
    • When re-adding a device that was supported by an earlier version of Gluon, a
      factory reset must be performed before checking the primary MAC address, as
      the setting from the old version is not reset otherwise.
  • Wired network
    • should support all network ports on the device
    • must have correct port assignment (WAN/LAN)
      • if there are multiple ports but no WAN port:
        • the PoE input should be WAN, all other ports LAN
        • otherwise the first port should be declared as WAN, all other ports LAN
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio -> led labeled "router" and led labeled "device" was controllable in openwrt but is off with gluon
      • Should show activity -> led labeled "router" and led labeled "device" was controllable in openwrt but is off with gluon
      • Should map to their respective port (or switch, if only one led present) -> no extra led
      • Should show link state and activity -> no extra led
  • Outdoor devices only:
    • Added board name to is_outdoor_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
  • Cellular devices only:
    • Added board name to is_cellular_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
    • Added board name with modem setup function setup_ncm_qmi to package/gluon-core/luasrc/lib/gluon/upgrade/250-cellular
  • Docs:
    • Added Device to docs/user/supported_devices.rst

@github-actions github-actions bot added 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support labels Jan 9, 2025
@herbetom
Copy link
Contributor

Looks good to me, just one clarification:

MAC-Address match eth0 and br-wan but not br-client (last digit changed)

The primary mac is the one one the status page or in the output of gluon-info. And that one matches with the one printed on the device? The mention of those interface names is just you wondering about that?

@maurerle
Copy link
Member

@fabianh95 ping

could you report if the information from the status page or in the output of gluon-info matches the label-mac written on the device?

@fabianh95
Copy link
Contributor Author

@herbetom Thanks for your answer and sorry for the late response.

I had a lot to do and I bought an EX6150 for testing.

XX:XX:XX:XX:XX:39 <--- printed on the device label and is the MAC-Address of eth0 and br-wan (via ifconfig)

gluon-info print XX:XX:XX:XX:XX:38, witch is the MAC-Address of client0, br-client and bat0 (via ifconfig)

On the EX6150 there is the same behavior, but on the device label are both MAC-Addresses printed. On the label from the EX6120 there is only one MAC-Address printed.

maurerle added a commit to maurerle/openwrt that referenced this pull request Jan 28, 2025
the label-mac should be set correctly on the ex6150 and ex6120.
This is required for gluon support.
See: freifunk-gluon/gluon#3420

Signed-off-by: Florian Maurer <[email protected]>
maurerle added a commit to maurerle/openwrt that referenced this pull request Jan 28, 2025
the label-mac should be set correctly on the ex6150 and ex6120.
This is required for gluon support.
See: freifunk-gluon/gluon#3420

Signed-off-by: Florian Maurer <[email protected]>
@maurerle
Copy link
Member

okay @fabianh95 - can you build the firmware for both devices with this patch applied and test if the mac is set correctly:
https://github.com/openwrt/openwrt/pull/17760.patch

The snippet below should then show the correct label-mac as printed on the device:

. /lib/functions.sh
. /lib/functions/system.sh
echo $(get_mac_label)

or just use firstboot, which regenerates the device mac as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants