Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediatek-mt7622: add support for Ubiquiti UniFi 6 LR v2 #2985

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Djfe
Copy link
Contributor

@Djfe Djfe commented Sep 14, 2023

EDIT:
Vielen Dank @heini66 , dass du das Gerät für uns getestet hast😊
https://forum.freifunk.net/t/unifi-6-long-range-hergestellt-1-haelfte-2022-besitzer-in-gesucht/23864/4

  • Must be flashable from vendor firmware
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())')
      ubiquiti-unifi-6-lr-v2
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging)
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
    70:a7:41:9c:e8:15
    • When re-adding a device that was supported by an earlier version of Gluon, a
      factory reset must be performed before checking the primary MAC address, as
      the setting from the old version is not reset otherwise.
  • Wired network
    • should support all network ports on the device
    • must have correct port assignment (WAN/LAN)
      • if there are multiple ports but no WAN port:
        • the PoE input should be WAN, all other ports LAN
        • otherwise the first port should be declared as WAN, all other ports LAN
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio
      • Should show activity
    • Switch port LEDs
      • Should map to their respective port (or switch, if only one led present)
      • Should show link state and activity
  • Outdoor devices only:
    • Added board name to is_outdoor_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
  • Cellular devices only:
    • Added board name to is_cellular_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
    • Added board name with modem setup function setup_ncm_qmi to package/gluon-core/luasrc/lib/gluon/upgrade/250-cellular
  • Docs:
    • Added Device to docs/user/supported_devices.rst

@github-actions github-actions bot added the 3. topic: hardware Topic: Hardware Support label Sep 14, 2023
@Djfe
Copy link
Contributor Author

Djfe commented Sep 14, 2023

What should be done about the UniFi 6 LR v2?
Upstream split the UniFi 6 LR into v1 and v2.

Apart from the LED color (v1 rgb, v2 dual static color) it's the exact same device and lots of people will have installed the existing image on v1 as well as v2 without knowing about this kind of revision. (ubiquiti didn't communicate it)
v2 was created recently because v3 needed to be created to add support for it.
The difference between v1 and v2 is (imo) negligible. I tested the dual static led with v3.
We should atleast add this image as broken imo.

Do you require this checklist to be filled? I don't have access to a v2 revision.

@blocktrron
Copy link
Member

Yes, this checklist is required. All in all, there is no point in adding this device to Gluon when nobody owns the device with intention to do so. If someone owns the device, he or she can verify support works as intended.

@Djfe Djfe marked this pull request as draft September 14, 2023 10:03
@Djfe
Copy link
Contributor Author

Djfe commented Sep 14, 2023

ok ok, maybe we can find someone, draft until then

@blocktrron
Copy link
Member

I'm closing this then. Feel free to re-open once the device has been verified working. Discussion can happen in the closed state in case somebody is interested in performing the necessary testing.

@blocktrron blocktrron closed this Sep 19, 2023
@rotanid rotanid reopened this Oct 18, 2023
@github-actions github-actions bot added the 3. topic: docs Topic: Documentation label Oct 18, 2023
@Djfe
Copy link
Contributor Author

Djfe commented Oct 18, 2023

Thanks for reopening. This device was tested by @heini66 and is ready to be merged.
apart from two things maybe:
wifi phy's have no permaddr, see #2982

and #3020 which doesn't prevent this device from working correctly and is a bug in Gluon and not with this device in particular.

@Djfe Djfe marked this pull request as ready for review October 19, 2023 13:44
@rotanid rotanid added the 2. status: waiting-on-author Waiting on some action from the author label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. status: waiting-on-author Waiting on some action from the author 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants