Exclude overlapping rides #95
Merged
+89
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlinorg
commented
Feb 9, 2025
| # part of the ride and one will be excluded. Just upload three rides instead. | ||
| # Allow some overlap at the start end, just in case .. things. | ||
| # Use local time because that's what is stored in the database. | ||
| def check_db_overlap( |
There was a problem hiding this comment.
This occurs when a single new strava activity comes in the MQ.
merlinorg
commented
Feb 9, 2025
| # If this rider has overlapping rides, just select the largest ride. This is because when | ||
| # we run a full sync the database may be empty so we pull all rides from Strava then filter | ||
| # and then insert, so filtering can't look at the database. | ||
| def overlaps_larger(activity, activities): |
There was a problem hiding this comment.
This occurs when we do a full rider sync, so we've pulled all activities and will then insert them in bulk.
merlinorg
force-pushed
the
no-overlapping-rides
branch
from
7ec6fbb to
9e11351
Compare
merlinorg
force-pushed
the
no-overlapping-rides
branch
from
9e11351 to
86dfdb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate rides, where riders are riding with multiple devices and forgetting to delete some Strava activities, currently tip the balance of victory. This will exclude such overlapping rides.
Resolves #34
This has been tested successfully.