Wech 35/bring storybook migration to main #337
Conversation
Docz is not supported anymore. We decided to migrate to a stable solution Co-authored-by: Zack Jones <[email protected]> Co-authored-by: Nikolai Lopin <[email protected]>
Components migrated: * Accordion * Banner * Box * Card
* Checkbox * Datepicker * Dimmer * Divider * Filepicker --------- Co-authored-by: Zack Jones <[email protected]> Co-authored-by: Cristian Sanchez <[email protected]> Co-authored-by: Nikolai Lopin <[email protected]>
* docs: add input story * docs: add label story * docs: add link story * docs: add modal story * docs: add offcanvas story * docs: define argTypes for Input and Label stories * docs(password): add Password to Storybook * docs(phoneinput): add PhoneInput to Storybook * fix(test): update snapshots * docs(pagination): add Pagination to Storybook * docs(radiobutton): add RadioButton to Storybook * docs(popover): add Popover to Storybook --------- Co-authored-by: Aleksandar Spasov <[email protected]> Co-authored-by: Ján Hamara <[email protected]>
Update typescript to the lowest supported version
* Input * Label * Link * Modal * Offcanvas Co-authored-by: Aleksandar Spasov <[email protected]> Co-authored-by: Nikolai Lopin <[email protected]>
* table * tag * text * textarea * toggle * tooltip --------- Co-authored-by: Christian <[email protected]> Co-authored-by: Nikolai Lopin <[email protected]>
* Search * TabBar * Select * SelectList * Skeleton Co-authored-by: Inga Schünemann <[email protected]>
* essentials pages * Logo * Icons --------- Co-authored-by: lena <[email protected]> Co-authored-by: Vanessa Knibbe <[email protected]> Co-authored-by: Nikolai Lopin <[email protected]>
There was a problem hiding this comment.
LGTM. I've checked out the branch, and it has started without issues.
Can you describe what was wrong with the Input? I see you removed the ResponsiveValue generic around it. I'm not sure it is correct. You can pass an array to size and variant props to make their style change based on the breakpoints.
I've assembled a demo in Codesandbox. If you make the browser tab narrower there, you'll see the change.
Hi Nik, nice catch! This was a change from a previous commit, I don't think it had any issue so I've put it back, running storybook locally it worked fine. I've had to put back some casts of |
martimalek
force-pushed
the
WECH-35/bring-storybook-migration-to-main
branch
from
4e54931 to
590ac14
Compare
|
I've resolved conflicts related to the recent addition of the compound The final docs look like: 
|
|
@martimalek do you plan to cherrypick Jan's new home page? |
Hey Nik, yes, I'll try cherrypicking today/tomorrow |
* feat(landing): add landing page for Storybook * docs(landing): finish the landing page integration * docs(theme): theme storybook with our branding * refactor(landingpage): mr review modifs part 1 * refactor(landing): wrap landing page mdx in unstyled component --------- Co-authored-by: Ján Hamara <[email protected]>
Fix up default font for theme to Open Sans (my bad, I left behind one commit and merged in the MR before pushing it) Relevant MR: #334
Update 'by Freenow' SVG with one with correct font (my bad, I left behind one commit and merged in the MR before pushing it) Relevant MR: #334
|
Alright folks, I've cherry-picked the commits for the landing page and changed their commit description to follow semantic commits rules I think this branch has now the entire Storybook migration and should be ready for some reviews and the release 😉 |
|
🎉 This PR is included in version 1.31.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
Bring the Storybook migration to main, this branch contains the whole Storybook migration without including the other breaking changes in #311
Why:
We want to migrate our documentation from docz to Storybook as part of the current major.
How:
I've created this branch from WECH-21/support-react-18 and rebased with
main, getting rid of anything unrelated to the Storybook migration (React 18 migration, removingnanoid, using React'suseIdto generate ids).Apart from that I've also:
ts-jestto 26.5.6 in order to use Jest 26 (introduced during the Storybook migration)Inputinternal utils that depended on it'ssizepropInfoBannerdocs to StorybookChecklist: