fix: increase WebSocket max message size to 100MB #1677
Conversation
The default WebSocket message size limit (~64KB) was too small for WASM contracts which can be several hundred KB. This caused PUT requests to be silently dropped at the protocol level, preventing contract deployment. Increased max_message_size to 100MB to handle large contracts. Fixes River invitation bug where PUT operations were failing silently. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
| ws.on_upgrade(on_upgrade) | ||
| // Increase max message size to 100MB to handle contract uploads | ||
| // Default is ~64KB which is too small for WASM contracts | ||
| ws.max_message_size(100 * 1024 * 1024) |
There was a problem hiding this comment.
I would consider this to be a temporal fix, we need to look into different ways of sending messages this large (maybe a regular multipart http request) cause this a bit of an antipattern for ws. I know is over local host but still, we can do better here .
I think eventually we want to stream that right into disk to not hold into such large things in memory for very long, but that requries a bigger architetural change.
| Ok(None) | ||
| .await; | ||
|
|
||
| match send_result { |
There was a problem hiding this comment.
this is the worst part that we were silently swallowing this. In the future we should have a regression test for this forcing some sort of error (it can be done at this component level by mocking the rest of the interface, e.g. dropping the other end of the channel).
good catch
Summary
Problem
The default WebSocket message size limit was too small for WASM contracts which can be several hundred KB (River's room contract is 360KB). This caused PUT requests to be silently dropped at the WebSocket protocol level before reaching Freenet's handler.
Solution
Added
max_message_size(100 * 1024 * 1024)configuration to the WebSocket upgrade handler.Testing
Related Issues
🤖 Generated with Claude Code