Fix build error with message: invalid initializer on 4.10.0 version kernel. #63

iysheng · 2024-09-27T10:43:12Z

Add kernel version compare based on torvalds/linux@2456e85

stappersg · 2024-09-27T19:25:45Z

Please do understand there is something as "commit summary" and "commit message".

And make the commit message matching the actual change.

iysheng · 2024-09-28T01:51:47Z

Please do understand there is something as "commit summary" and "commit message".

And make the commit message matching the actual change.

Maybe I need to change the commit message later.
As you can see the commit of torvalds/linux@2456e85. The changes of ktime_t type was in v4.10.rc1， so I add a compare with KERNEL_VERSION(4,10,0)。But I found the build error was on a centos 7 PC with kernel 3.10.0 version，Linux localhost.localdomain 3.10.0-1160.71.1.el7.x86_64 #1 SMP Tue Jun 28 15:37:28 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux I'm so sorry to make this confused misunderstandings。

stappersg · 2024-09-28T06:51:46Z

On Fri, Sep 27, 2024 at 06:52:08PM -0700, Yang sheng wrote: > Please do understand there is something as _"commit summary"_ and _"commit message"_. 1. Maybe I need to change the commit message later.

Just do it

> And make the commit message matching the actual change. > 2. As you can see the commit of torvalds/linux@2456e85. The changes of ``ktime_t`` type was in ``v4.10.rc1``， so I add a compare with **KERNEL_VERSION(4,10,0)**。

Current commit message says 3.10, actual change says 4.10. Groeten Geert Stappers -- Silence is hard to parse

stappersg · 2024-09-28T07:18:01Z

There was an update.

stappers@paddy:~/src/githubforks/tty0tty
$ git show
commit a074fb57e876bb5240d8a85f0ffa99561cf1a412 (HEAD -> mr63, iysheng/master)
Author: iysheng <[email protected]>
Date:   Fri Sep 27 18:36:57 2024 +0000

    Fix build error for kernel < 4.10.0
    
    See https://github.com/torvalds/linux/commit/2456e855354415bfaeb7badaa14e11b3e02c8466
    
    Signed-off-by: iysheng <[email protected]>

diff --git a/module/tty0tty.c b/module/tty0tty.c
index 03a7455..3224675 100644
--- a/module/tty0tty.c
+++ b/module/tty0tty.c
@@ -228,7 +228,11 @@ static int tty0tty_write(struct tty_struct *tty, const unsigned char *buffer,
        int retval = 0;
        struct tty_struct *ttyx = NULL;
        u64 elapsed, delay;
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,10,0)
        ktime_t start_time = ktime_get_ns();
+#else
+       u64 start_time = ktime_get_ns();
+#endif
 
        if (!tty0tty)
                return -ENODEV;
stappers@paddy:~/src/githubforks/tty0tty
$

Now waiting on a new attempt.

iysheng · 2024-09-28T10:49:11Z

There was an update.

stappers@paddy:~/src/githubforks/tty0tty
$ git show
commit a074fb57e876bb5240d8a85f0ffa99561cf1a412 (HEAD -> mr63, iysheng/master)
Author: iysheng <[email protected]>
Date:   Fri Sep 27 18:36:57 2024 +0000

    Fix build error for kernel < 4.10.0
    
    See https://github.com/torvalds/linux/commit/2456e855354415bfaeb7badaa14e11b3e02c8466
    
    Signed-off-by: iysheng <[email protected]>

diff --git a/module/tty0tty.c b/module/tty0tty.c
index 03a7455..3224675 100644
--- a/module/tty0tty.c
+++ b/module/tty0tty.c
@@ -228,7 +228,11 @@ static int tty0tty_write(struct tty_struct *tty, const unsigned char *buffer,
        int retval = 0;
        struct tty_struct *ttyx = NULL;
        u64 elapsed, delay;
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,10,0)
        ktime_t start_time = ktime_get_ns();
+#else
+       u64 start_time = ktime_get_ns();
+#endif
 
        if (!tty0tty)
                return -ENODEV;
stappers@paddy:~/src/githubforks/tty0tty
$

Now waiting on a new attempt.

As you can see, I changed the commit message.😊

stappersg · 2024-09-28T12:28:32Z

On Sat, Sep 28, 2024 at 03:49:31AM -0700, Yang sheng wrote: I changed the commit message.😊

Still waiting on a new attempt.

kernel See torvalds/linux@2456e85 Signed-off-by: iysheng <[email protected]>

iysheng · 2024-09-28T12:56:06Z

On Sat, Sep 28, 2024 at 03:49:31AM -0700, Yang sheng wrote: I changed the commit message.😊
Still waiting on a new attempt.

How about the new commit message, I changed again.

stappersg · 2024-09-28T13:28:02Z

stappers@paddy:~/src/githubforks/tty0tty
$ git show
commit 0bc63b7602a25d859150cd2373327b0929de8e6b
Author: iysheng <[email protected]>
Date:   Fri Sep 27 18:36:57 2024 +0000

    Fix build error with message: invalid initializer on < 4.10.0 version
    kernel
    
    See https://github.com/torvalds/linux/commit/2456e855354415bfaeb7badaa14e11b3e02c8466
    
    Signed-off-by: iysheng <[email protected]>

diff --git a/module/tty0tty.c b/module/tty0tty.c
index 03a7455..3224675 100644
--- a/module/tty0tty.c
+++ b/module/tty0tty.c
@@ -228,7 +228,11 @@ static int tty0tty_write(struct tty_struct *tty, const unsigned char *buffer,
 	int retval = 0;
 	struct tty_struct *ttyx = NULL;
 	u64 elapsed, delay;
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,10,0)
 	ktime_t start_time = ktime_get_ns();
+#else
+	u64 start_time = ktime_get_ns();
+#endif
 
 	if (!tty0tty)
 		return -ENODEV;
stappers@paddy:~/src/githubforks/tty0tty
$

stappersg · 2024-09-28T13:41:04Z

On Sat, Sep 28, 2024 at 06:28:23AM -0700, Geert Stappers wrote: ***@***.***:~/src/githubforks/tty0tty $ git show commit 0bc63b7 Author: iysheng ***@***.***> Date: Fri Sep 27 18:36:57 2024 +0000 Fix build error with message: invalid initializer on < 4.10.0 version kernel See torvalds/linux@2456e85 Signed-off-by: iysheng ***@***.***> diff --git a/module/tty0tty.c b/module/tty0tty.c index 03a7455..3224675 100644 --- a/module/tty0tty.c +++ b/module/tty0tty.c @@ -228,7 +228,11 @@ static int tty0tty_write(struct tty_struct *tty, const unsigned char *buffer, int retval = 0; struct tty_struct *ttyx = NULL; u64 elapsed, delay; +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,10,0) ktime_t start_time = ktime_get_ns(); +#else + u64 start_time = ktime_get_ns(); +#endif if (!tty0tty) return -ENODEV; ***@***.***:~/src/githubforks/tty0tty $

The next attempt has a much better commit message. Groeten Geert Stappers -- Silence is hard to parse

iysheng · 2024-09-29T00:06:58Z

On Sat, Sep 28, 2024 at 06:28:23AM -0700, Geert Stappers wrote:
@.:~/src/githubforks/tty0tty
$ git show
commit 0bc63b7
Author: iysheng @.>
Date: Fri Sep 27 18:36:57 2024 +0000
Fix build error with message: invalid initializer on < 4.10.0 version
kernel

See https://github.com/torvalds/linux/commit/2456e855354415bfaeb7badaa14e11b3e02c8466

Signed-off-by: iysheng ***@***.***>
diff --git a/module/tty0tty.c b/module/tty0tty.c
index 03a7455..3224675 100644
--- a/module/tty0tty.c
+++ b/module/tty0tty.c
@@ -228,7 +228,11 @@ static int tty0tty_write(struct tty_struct *tty, const unsigned char *buffer,
int retval = 0;
struct tty_struct *ttyx = NULL;
u64 elapsed, delay;
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,10,0)
ktime_t start_time = ktime_get_ns();
+#else

u64 start_time = ktime_get_ns();
+#endif

if (!tty0tty)
return -ENODEV;
@.***:~/src/githubforks/tty0tty
$
The next attempt has a much better commit message.

Groeten
Geert Stappers

Silence is hard to parse

tks, do you have any better suggestions?

stappersg · 2024-10-06T10:06:21Z

On Sat, Sep 28, 2024 at 05:07:21PM -0700, Yang sheng wrote: > On Sat, Sep 28, 2024 at 06:28:23AM -0700, Geert Stappers wrote: > > $ git show > > commit 0bc63b7 > > > > Fix build error with message: invalid initializer on < 4.10.0 version kernel > > > > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,10,0) > > The next attempt has a much better commit message. > tks, do you have any better suggestions?

Commit 9452a60 as a commit message with a **why** and with a commit summary below the maximum of 50 characters. And it is **without** contradicting actual change and commit message. (It has no conflict "< 4.10" versus ">= 4.10".) Groeten Geert Stappers P.S. Please "acknowledge" by closing the merge request. -- Silence is hard to parse

iysheng force-pushed the master branch from 0322abb to a074fb5 Compare September 28, 2024 02:04

stappersg changed the title ~~Fix build error with message: invalid initializer on 3.10.0 version kernel.~~ Fix build error with message: invalid initializer on 4.10.0 version kernel. Sep 28, 2024

Fix build error with message: invalid initializer on < 4.10.0 version

0bc63b7

kernel See torvalds/linux@2456e85 Signed-off-by: iysheng <[email protected]>

iysheng force-pushed the master branch from a074fb5 to 0bc63b7 Compare September 28, 2024 12:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix build error with message: invalid initializer on 4.10.0 version kernel. #63

Fix build error with message: invalid initializer on 4.10.0 version kernel. #63

iysheng commented Sep 27, 2024

stappersg commented Sep 27, 2024

iysheng commented Sep 28, 2024 •

edited

Loading

stappersg commented Sep 28, 2024 via email

stappersg commented Sep 28, 2024

iysheng commented Sep 28, 2024

stappersg commented Sep 28, 2024 via email

iysheng commented Sep 28, 2024

stappersg commented Sep 28, 2024

stappersg commented Sep 28, 2024 via email

iysheng commented Sep 29, 2024

Groeten
Geert Stappers

stappersg commented Oct 6, 2024 via email

Fix build error with message: invalid initializer on 4.10.0 version kernel. #63

Are you sure you want to change the base?

Fix build error with message: invalid initializer on 4.10.0 version kernel. #63

Conversation

iysheng commented Sep 27, 2024

stappersg commented Sep 27, 2024

iysheng commented Sep 28, 2024 • edited Loading

stappersg commented Sep 28, 2024 via email

stappersg commented Sep 28, 2024

iysheng commented Sep 28, 2024

stappersg commented Sep 28, 2024 via email

iysheng commented Sep 28, 2024

stappersg commented Sep 28, 2024

stappersg commented Sep 28, 2024 via email

iysheng commented Sep 29, 2024

Groeten Geert Stappers

stappersg commented Oct 6, 2024 via email

iysheng commented Sep 28, 2024 •

edited

Loading

Groeten
Geert Stappers