Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed default value to resolve php 8.0 deprecation error #8

Open
wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from

Conversation

nilesh-axelerant
Copy link

While updating the PHP version from 7.3 to 8.0 below errors were generated.

PHP Deprecated: Required parameter $contextHelper follows optional parameter $table in /var/www/html/web/modules/contrib/purl/src/Routing/PurlRouteProvider.php on line 114
Deprecated: Required parameter $contextHelper follows optional parameter $table in /var/www/html/web/modules/contrib/purl/src/Routing/PurlRouteProvider.php on line 114
PHP Deprecated: Required parameter $matchedModifiers follows optional parameter $table in /var/www/html/web/modules/contrib/purl/src/Routing/PurlRouteProvider.php on line 114
Deprecated: Required parameter $matchedModifiers follows optional parameter $table in /var/www/html/web/modules/contrib/purl/src/Routing/PurlRouteProvider.php on line 114

Raised PR to resolve the above warnings.

@rbran100
Copy link

rbran100 commented Dec 6, 2023

@freelock Can we get this merged in? Any changes you would like to see? I am happy to help manage these if you want as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants