make codegen always use 'experimental' navigation #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielittner
requested review from
a team and
befrvnk
and removed request for
a team
befrvnk
reviewed
Apr 29, 2024
| addStatement("%M(", androidxNavHost) | ||
| } | ||
| } | ||
| .addStatement("%M(", experimentalNavHost) |
There was a problem hiding this comment.
Suggested change
| .addStatement("%M(", experimentalNavHost) | |
| .addStatement("%M(", navHost) |
What do you say about renaming this to navHost to prevent confusion?
There was a problem hiding this comment.
Makes sense 👍 f09d3e2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of removing AndroidX navigation the codegen will now always use Khonshu's own navigation implementation. The generated code will be as if
experimentalNavigationistrue(the option has been removed), but without the ability to decide between androidx and experimental at runtime.