CI: New workflows for tests #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould be used instead
|
Ready to merge |
|
Nice job, but I think it's also important to reintroduce Dependabot&Renovatebot so I created this #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work for #10
It removes all workflows and recreates for tests only: unit tests, integration tests, and linter.
The others were related to the releases (it'll be recreated again in separate PR) and handling issues/labels, however this project has only the default labels so workflows fail.
I would like to (re)introduce https://github.com/release-drafter/release-drafter in a separate PR. Probably we don't need to automate releases now when the rebrading is not yet finished.
unit and integration tests are run on 3 all platforms (maybe it is not important for unit tests?)
Now, the default for
build:appis to build only for the current OS, then it is possible to add the explicit target. It speeds up integration test as the target might bedirfor current arch only by adding explicit CLI arguments forelectron-builder.linter test is run only on Ubuntu.
Also, PR removes all editor-related directories: both .idea and .vscode. I.e., I use VScode and don't think forcing anybody with my local configuration would be a good idea.
As a bonus: the main screenshot is replaced and presents the current version of Freelens.
Please squash it.