Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working with eyecite recently and found some details when i was trying to add new test examples (24 Del. (1 Boyce) 1, Ridgely's Notebook, 362, Bayard’s Notebook, 235), the regex volume_nominative should have the capturing group called volume like the others, since in the end it is a volume number. I think this is important to have consistency in volume regexes.
I changed this
(?:(?P<volume_nominative>\d{1,2}) )?
to
(?:(?P<volume>\d{1,2}) )?
But when doing this other problems arise with the regexes of some reporters since there is a regex like this:
$volume $reporter \\($volume_nominative(?P<reporter_nominative>MacArth\\. & M\\.|Tuck\\. & Cl\\.|MacArth\\.|Mackey|Cranch)\\) $page
It is not possible to have repeated capture names in a regex, so we had to modify those, so i updated those kind of regexes to this:
$volume $reporter \((?:(?P<parallel_volume>\d{1,2}) )?(?P<parallel_reporter>MacArth\. & M\.|Tuck\. & Cl\.|MacArth\.|Mackey|Cranch)\) $page
I renamed the groups in the parallel citations in parentheses, e.g.
24 Del. (1 Boyce) 1