Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nominative related stuff #192

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update nominative related stuff #192

wants to merge 2 commits into from

Conversation

quevon24
Copy link
Member

I've been working with eyecite recently and found some details when i was trying to add new test examples (24 Del. (1 Boyce) 1, Ridgely's Notebook, 362, Bayard’s Notebook, 235), the regex volume_nominative should have the capturing group called volume like the others, since in the end it is a volume number. I think this is important to have consistency in volume regexes.

I changed this

(?:(?P<volume_nominative>\d{1,2}) )?

to

(?:(?P<volume>\d{1,2}) )?

But when doing this other problems arise with the regexes of some reporters since there is a regex like this:

$volume $reporter \\($volume_nominative(?P<reporter_nominative>MacArth\\. & M\\.|Tuck\\. & Cl\\.|MacArth\\.|Mackey|Cranch)\\) $page

It is not possible to have repeated capture names in a regex, so we had to modify those, so i updated those kind of regexes to this:

$volume $reporter \((?:(?P<parallel_volume>\d{1,2}) )?(?P<parallel_reporter>MacArth\. & M\.|Tuck\. & Cl\.|MacArth\.|Mackey|Cranch)\) $page

I renamed the groups in the parallel citations in parentheses, e.g. 24 Del. (1 Boyce) 1

@quevon24 quevon24 requested a review from flooie December 19, 2024 23:23
freelawbot added a commit that referenced this pull request Dec 19, 2024
@freelawbot
Copy link

The Eyecite Report 👁️

Gains and Losses

There were 0 gains and 0 losses.

Click here to see details.
id Gain Loss

Time Chart

image

Generated Files

Branch 1 Output
Branch 2 Output
Full Output CSV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants