New reporters and reporters variations #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freelawbot
added a commit
that referenced
this pull request
Nov 8, 2024
freelawbot
added a commit
that referenced
this pull request
Nov 11, 2024
new reporters variations
freelawbot
added a commit
that referenced
this pull request
Nov 12, 2024
flooie
reviewed
Nov 13, 2024
Comment on lines
+893
to
+897
| "examples": [ | ||
| "11 Am. Ann. Cas. 198", | ||
| "Am.Ann.Cas. 1916C, 1093", | ||
| "Am.Ann.Cas. 1916E,157" | ||
| ], |
There was a problem hiding this comment.
@quevon24 you added these cases but this isnt doing anything. The standard is a full cite if no regex is set.
Two of these are totally non functional - which makes me wonder if we have other situations where we've simply added examples but not implemented them.
We had a number of reporters with atypical citation patterns that while we listed examples we were not capturing. This adds examples for those and add a regex for all reporters with examples.
freelawbot
added a commit
that referenced
this pull request
Nov 13, 2024
The Eyecite Report 👁️Gains and LossesThere were 0 gains and 0 losses. Click here to see details.
Time Chart
Generated Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New reporters variations added and new reporters added:
Update: I had to update the lint workflow to force a specific version of black because the latest version does not support python 3.8. The latest supported version is 22.8.0