2023.09.27.acms permissions #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Comments are not technically allowed in JSON files, although Chrome and
Firefox both support them in manifest.json.)
Add permissions support for ACMS websites, both the two we know about
today and the remainder we can reasonably anticipate, as well as the
filing websites and the email domains, which we do not currently use.
Because asking users to accept new permissions is a big deal, we want
to minimize it, so try hard to predict anything we might reasonably
want, without resorting to excessive wildcarding.
The Ninth and Second circuits have collaboratively worked together to
develop ACMS, "Appellate Court Management System," their replacement
for CM/ECF as the AOUSC works to find a CM/ECF replacement for all
courts.
Documents are served from ca{2,9}-showdoc.azurewebsites.us.
Filing users login via ca{2,9}-portal.powerappportals.us.
Email notices (NDAs) are sent from @ca{2,9}.fedcourts.us.
This is too complicated to be a single-line regexp anymore. Handle guard for a falsy `url` parameter first, explicitly. Test for a CM/ECF or PACER url match first, then test for ACMS. Return null on failure.
Add successful tests for ACMS documents and dockets, and unsuccessful ones for filing URLs, as well as other Azure government sites and fedcourts.us, which is an email domain that has no associated website(s) that we are aware of.
|
I'm merging this because it looks good, has tests, and is well documented, but @ERosendo it wouldn't hurt for you to take a look at it too and see if it needs any further tweaks. If you find that it doesn't, can you please do a release today? |
|
Sure. I'll take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIMELY: Add permissions for ACMS websites, as well initial filtering for those URLs in
getCourtFromURL(), and requisite tests. This is important to get people to acknowledge the permissions changes as early as practicable before the Oct. 1, 2023 deadline, even though we still lack actual support for ACMS.