Parse appellate docket attachments #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlissner
reviewed
Oct 13, 2023
There was a problem hiding this comment.
This looks generally good to me. @albertisfu when you have a moment (after Elastic and RECAP), can you take a look at this, please?
albertisfu
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
@mlissner this looks good to me.
I just apply a refactor to move a couple of common methods to avoid duplicated code:
get_file_size_str_from_tr and get_input_value_from_tr, which were almost identical across appellate_docket, attachment_page, and docket_report.
I also added type hints and an additional test for a court that does not use entry numbers.
mlissner
approved these changes
Dec 31, 2024
|
Thanks all! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure if these
pacer_seq_no's are correct but they seem to follow a similar pattern to district courts at least.