Merge pull request #251 from freelawproject/fix-EOY-dialog-condition

fix(EOY_dialog): prevent first dialog from appearing after its end date.
freelawproject · Dec 24, 2024 · 826b7d8 · 826b7d8
2 parents cbb32f2 + 636fd2c
commit 826b7d8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/components/dialog.js b/components/dialog.js
@@ -75,7 +75,7 @@ export function EOYDialog() {
     const secondEOYDialogDismissalDate = localStorage.getItem('secondEOYDialogDismissalDate');
     const secondDismissed = dismissedWithinWeek(secondEOYDialogDismissalDate);
 
-    if (!firstDismissed && dialogStart <= today <= firstDialogEnd) {
+    if (!firstDismissed && dialogStart <= today && today <= firstDialogEnd) {
       setDialogVersion('first');
       setIsOpen(true);
     } else if (!secondDismissed && firstDialogEnd <= today && today <= secondDialogEnd) {