update django to pick up CVEs #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heres the full list of django vulnerabilities in doctor |
|
Hm, lots of failing tests. I wonder if that's just because other things are broken. Perhaps #187 will fix that.... |
|
I don't see fixes in #187 that'd help here, so I think these are things that genuinely get broken by the upgrade. |
|
It looks like the server is returning 500s but I don't see the server logs in the test failures. Do you know how to see that? |
|
You know, I really can't imagine how this version bump of Django would cause so much wreckage. I'm going to just merge, and we'll get this fixed in another PR if needed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2022-28346 as example. but handful found in google container scanning