Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks.extract_from_html): Catch UnicodeDecodeError #182

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

grossir
Copy link
Contributor

@grossir grossir commented Feb 27, 2024

UnicodeDecodeError was bubbling because except clause was not catching it

Solves #181

UnicodeDecodeError was bubbling because except clause was not catching it

Solves freelawproject#181
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Do we need the DoctorUnicodeDecodeError anymore?

Copy link
Collaborator

@flooie flooie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grossir

@flooie flooie merged commit c293ea6 into freelawproject:main Feb 27, 2024
4 checks passed
@flooie
Copy link
Collaborator

flooie commented Feb 27, 2024

@mlissner - sorry to get in the way of this.

@mlissner
Copy link
Member

We passed like ships in the night! My thought was that if we want to remove it — you tell me — I could do it and then we'd know if my magic powers fix the deployment workflow.

@flooie
Copy link
Collaborator

flooie commented Feb 27, 2024

I say let it disappear into the ether.

@mlissner
Copy link
Member

Hm, there's something interesting (clever?) going on here:

except UnicodeDecodeError as e:
if not isinstance(s, Exception):
raise DoctorUnicodeDecodeError(s, *e.args)

Hm...I don't have time to think through if we want to remove that or if it's doing something useful, but happy to do what you say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants