refactor(doctor): Clean up Dead Stuff #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnludwigm
commented
Dec 21, 2023
doctor/lib/mojibake.py
Outdated
| @@ -47,7 +47,6 @@ def fix_mojibake(text): | |||
| "Ò": "N", | |||
| "Ñ": "O", | |||
| "Ð": "P", | |||
| "": "Q", # Missing | |||
There was a problem hiding this comment.
Key is overwritten in L56
There was a problem hiding this comment.
That's actually deliberate to document how we don't have the replacement keys for Q or X.
There was a problem hiding this comment.
@mlissner fixed now. Should be good to go.
mlissner
requested changes
Dec 21, 2023
mlissner
approved these changes
Dec 21, 2023
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking at the code and figured I'd run the standard clean-up stuff.