feat(contact_form): Add more issue types to ContactForm #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thank you! |
|
One small comment for you, @elisa-a-v. Please try to use the auto-closing tricks that Github has so that issues get automatically closed when PRs are merged: E.g., if you had said "Fixes #4648" above, instead of "Addresses #4648", it would have auto-closed. Handy! But nice little PR otherwise. Commit messages look good, code is clean. Nice stuff. I'm nitpicking because that's all I've got! |
|
You can put it in a commit too. It's a great little feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4615
This PR adds more choices for issue types in the contact form so it now includes:
It also changes the label for support so it now says "General Support".