Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QtSvg dependency to Debian #503

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Add QtSvg dependency to Debian #503

merged 2 commits into from
Aug 5, 2023

Conversation

deeplow
Copy link
Contributor

@deeplow deeplow commented Aug 3, 2023

Fixes #500

@deeplow deeplow added this to the 0.4.2 milestone Aug 3, 2023
@deeplow deeplow requested a review from apyrgio August 3, 2023 19:23
@deeplow
Copy link
Contributor Author

deeplow commented Aug 3, 2023

I sneaked in the one about making env.py run in GUI mode, since it when it got to the make test part of qa.py it failed misteriously with a segfault by pyside. The reason was that it did not run those tests in GUI mode.

apyrgio
apyrgio approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@apyrgio apyrgio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I also sent a small FIXUP to remove a stale --gui flag, and an extra test to check that our imports work, when we start the Dangerzone GUI. Feel free to merge it.

deeplow added 2 commits August 5, 2023 17:02
@deeplow
env.py: make env run in GUI mode (--no-gui otherwise)
356f835 
Now that we have GUI tests, it makes more sense to have running with
the X11 socket mounted in the environment than not.
@deeplow
Add python3-pyside2.qtsvg dependency to debian builds
b7e212e 
When the updater was added in commit 5b17f75 [1], it it had missed
the dependencies on Debian.

[1]: 5b17f75
@deeplow deeplow merged commit b7e212e into main Aug 5, 2023
@deeplow
Copy link
Contributor Author

deeplow commented Aug 5, 2023

I also sent a small FIXUP to remove a stale --gui flag, and an extra test to check that our imports work, when we start the Dangerzone GUI. Feel free to merge it.

Thanks for spotting that

@deeplow deeplow deleted the 500-pyside-qtsvg branch August 9, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apyrgio apyrgio apyrgio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.2
Development

Successfully merging this pull request may close these issues.

0.4.2 build on ubuntu 22.04 can't import PySide2.QtSvg
2 participants
@deeplow @apyrgio