A hook for mounting an extra-patches directory into the jail #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been using this for over two years. It was recently updated based upon suggestions: https://gist.github.com/dlangille/924507ce545de8fbbe78b50b752997ce Background:https://dan.langille.org/2019/08/10/poudriere-hooks/
bdrewery
reviewed
Oct 15, 2021
bdrewery
requested changes
Oct 15, 2021
Change /usr/local/etc/poudriere.d/local-patches to ${POUDRIERED}/local-patches
This morning my cronjob was spewing errors: mkdir: /usr/local/poudriere/data/.m/122amd64-default-primary/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-primary/01/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-primary/04/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-primary/03/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-primary/02/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-mysql57/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-mysql80/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-pg96/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-pg10/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-pg11/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-pg12/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-pg13/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122amd64-default-unifi/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/122i386-default-primaryi386/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-primary/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-primary/03/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-primary/04/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-primary/01/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-primary/02/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-mysql57/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-mysql80/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-pg96/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-pg10/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-pg11/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-pg12/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-pg13/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13amd64-default-unifi/ref/local-patches: File exists mkdir: /usr/local/poudriere/data/.m/13i386-default-primaryi386/ref/local-patches: File exists
|
Removing the directory check produced many errors in my overnight cronjob. I reverted that change and pushed it. |
jlduran
reviewed
Oct 17, 2021
Reported by: Mark Millard
build_repo is currently blocked for dry run modes and building the repo in a test situation does not seem prudent. For now just disable this as it is very new. Fixes 1ee1367
Reported by: ler
Seems I did not include the -p when I removed the if during my testing.
|
My latest push brought in commits unrelated to the hook. I'll fix that up. |
|
Still not merged after two years ? Any concerns ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this for over two years. It was recently updated
based upon suggestions:
https://gist.github.com/dlangille/924507ce545de8fbbe78b50b752997ce
Background:https://dan.langille.org/2019/08/10/poudriere-hooks/