Fix jail update with patch: #317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert previously applied patch and remove orphan files before attempt to run 'svn up'. Otherwise conflicts can break src. Reapply patch after update src.
|
I'm still a bit nervous about putting this change in. I think we might cause unexpected problems by always reverting before an update. Someone might purposely have their own customizations in the tree that they could lose here silently. Plus it might make more sense to generalize this and have the entire jail rolled back to the "clean" snapshot before upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert previously applied patch and remove orphan files before attempt
to run 'svn up'. Otherwise conflicts can break src.
Reapply patch after update src.