Fetch packages after removing what we need to rebuild, not before that. #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not before that. This change from PR freebsd#1101 is still actual: freebsd#1101 freebsd@bc6b07b
|
Yes the plan is for #822 to address. Or at least come in first before making more changes to the ordering. |
dsh2dsh
added a commit
to dsh2dsh/poudriere
that referenced
this pull request
Apr 22, 2024
rebuild only changed dependencies. Without this change poudriere rebuild changed ports, ports with changed dependencies and ports with dependencies with changed dependencies. For instance: Deleting vulkan-loader-1.3.273.pkg: new version: 1.3.274 Deleting ffmpeg-6.1_1,1.pkg: missing dependency: vulkan-loader-1.3.273 Deleting firefox-121.0,2.pkg: missing dependency: ffmpeg-6.1_1,1 firefox-121.0,2 doesn't depend on vulkan-loader-1.3.273, but poudriere removes it too, because ffmpeg-6.1_1,1 was removed. Now poudriere will remove ffmpeg-6.1_1,1, but keep firefox-121.0,2, because version of ffmpeg will not change after rebuilding and firefox-121.0,2 will have valid dependencies. The same step now looks: Deleting vulkan-loader-1.3.273.pkg: new version: 1.3.274 Keeping ffmpeg-6.1_1,1.pkg: missing dependency: vulkan-loader-1.3.273 ... after processing dependencies Deleting ffmpeg-6.1_1,1: missing dependency As you can see it will not rebuild firefox and finish everything faster. See PR freebsd#1101 and freebsd#1148.
dsh2dsh
added a commit
to dsh2dsh/poudriere
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think, this change from PR #1101 is still actual:
#1101
bc6b07b