Skip to content

Commit

Permalink
Revert "pkgqueue_get_next: find(1) in the queue should not fail"
Browse files Browse the repository at this point in the history
This reverts commit 11baebf.

The find(1) is racy. The callers handle the situation properly.

	find: unbalanced/run:qt6-quicktimeline-6.6.3: No such file or directory
	[00:07:25] Error: [92639] /usr/local/share/poudriere/bulk.sh:pkgqueue_get_next:12:pkgqueue_get_next: Failed to search queue
  • Loading branch information
bdrewery committed May 12, 2024
1 parent fd1931e commit 5664bab
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/share/poudriere/include/pkgqueue.sh
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,7 @@ pkgqueue_get_next() {
# May need to try multiple times due to races and queued-for-order jobs
while :; do
pkgq_dir="$(find ${POOL_BUCKET_DIRS:?} \
-type d -depth 1 -empty -print -quit)" ||
err "${EX_SOFTWARE}" "pkgqueue_get_next: Failed to search queue"
-type d -depth 1 -empty -print -quit || :)"
# No more eligible work!
case "${pkgq_dir}" in
"")
Expand Down

0 comments on commit 5664bab

Please sign in to comment.