Add initial GitHub Actions support for kyua #254
Conversation
ngie-eign
force-pushed
the
add-gh-actions
branch
4 times, most recently
from
dd72073 to
3f1cbfe
Compare
This proposed GitHub Actions workflow file runs tests on MacOS and Ubuntu Linux, similar to what is being proposed in freebsd/atf#93 . The delta between this change and the one being made in ATF mostly relates to the additional package dependencies, e.g., with and without ATF. Kyua is built from scratch because of issues with dependent packages and runtime linker collisions on both MacOS and Ubuntu. The binary package versions are built against a different version of Lutok, ergo they can have runtime linker collisions. Signed-off-by: Enji Cooper <[email protected]>
ngie-eign
force-pushed
the
add-gh-actions
branch
from
3f1cbfe to
3ade26e
Compare
|
Why neglect the primary target platform? We could easily do CI on FreeBSD using Cirrus CI instead of Github Actions. |
I have an issue filed to reenable Cirrus CI. The goal of adding GH actions is to cover Linux and MacOS because the tooling for LLVM isn’t there on FreeBSD, and a lot of the GH issues being filed are coming from Linux and MacOS users. |
| - pkgconf | ||
| - [email protected] | ||
| - sqlite | ||
| enable-atf-pkgs: |
There was a problem hiding this comment.
Since the below line is commented out, add brackets to make this valid YAML
| enable-atf-pkgs: | |
| enable-atf-pkgs: [] |
Oh, I didn't notice that issue. But yes, this PR looks fine for Linux and OSX |
| # | ||
| env: | ||
| ATF_REPO: freebsd/atf | ||
| ATF_REF: atf-0.22 |
There was a problem hiding this comment.
I would propose to build and test it against development branches of atf and lutok. It could add chances that it's tested against the recent changes in the dependencies sooner, not to get surprised much later during release engineer etc. If required, a release could be a separate branch tagged where this config is changed to strict versions. Another option is to make GHA matrix include the latest versions (master/main) plus the latest released version -- that's for cases when Kyua could link & use non-latest version of dependencies.
Perhaps, we should finish s/master/main/ for all three projects first (like this: freebsd/atf#94), not to come back here due to failed jobs or so.
| # LUTOK_REPO: freebsd/lutok | ||
| # LUTOK_REF: master | ||
| LUTOK_REPO: ngie-eign/lutok | ||
| LUTOK_REF: build-cleanup |
There was a problem hiding this comment.
I guess it will eventually switch back to the freebsd/lutok repo. It may stay like this unnoticed for long time w/o expected outcome of CI builds.
This proposed GitHub Actions workflow file runs tests on MacOS and Ubuntu Linux, similar to what is being proposed in freebsd/atf#93 .
The delta between this change and the one being made in ATF mostly relates to the additional package dependencies, e.g., with and without ATF.
Kyua is built from scratch because of issues with dependent packages and runtime linker collisions on both MacOS and Ubuntu. The binary package versions are built against a different version of Lutok, ergo they can have runtime linker collisions.