Fix running executor_pid_test on ZFS
#234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vangyzen
approved these changes
Nov 30, 2024
The testcases prior to this change relied on setting UF_NOUNLINK, which is unfortunately bugged on ZFS: ZFS does not treat UF_NOUNLINK as a valid value for fflags, which causes the testcases to fail. Switch to SF_NOUNLINK. This particular fflag works work ZFS, unlike UF_NOUNLINK, but requires root privileges, so add the needed metadata to the Kyuafile. As part of this, I needed to convert the test from atf-c++(3) to atf-c(3). The atf-c++(3) APIs do not have the printf-like equivalent formatting, so it was very difficult figuring out why things weren't working in atf-c++(3). While here, clean up the code to DRY some of the repeated logic that it contained. The UF_NOUNLINK bug has been reported in openzfs/zfs#16809 . Fixes: e26c804
ngie-eign
force-pushed
the
fix-executor-pid-test-on-zfs
branch
from
f0c14f1 to
16ab764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testcases prior to this change relied on setting UF_NOUNLINK, which is unfortunately bugged on ZFS: ZFS does not treat UF_NOUNLINK as a valid value for fflags, which causes the testcases to fail.
Switch to SF_NOUNLINK. This particular fflag works work ZFS, unlike UF_NOUNLINK, but requires root privileges, so add the needed metadata to the Kyuafile.
As part of this, I needed to convert the test from atf-c++(3) to atf-c(3). The atf-c++(3) APIs do not have the printf-like equivalent formatting, so it was very difficult figuring out why things weren't working in atf-c++(3).
While here, clean up the code to DRY some of the repeated logic that it contained.
The UF_NOUNLINK bug has been reported in openzfs/zfs#16809 .
Fixes: e26c804