-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmem.9: align lists + tag spdx #1456
Conversation
MFC after: 3 days Reported by: gperciva, mhorne
I have no major objection to this. Some slight concern over whether "qcache_max" will be updated in the future -- suppose that 15 years from now, somebody adds a longer argument to One option would be to add a comment above each However, I tried writing a proof-of-concept python script to detect such instances, and it looks like it works. So if there's a desire to do so, one could automatically discover all instances of (That said, there's a lot of such instances. Out of the 40 files in Anyway, as far as I'm concerned, go ahead and merge this. :) |
You're definitely more experienced and educated than me and really I hope to learn from you, but I don't agree with this. Doc mistakes come from not looking at the doc and changing it. Doc is for humans to read. The flow and presentation of the document is important, and affects it's functionality, and can't be obtained if you don't read the whole doc while you're editing it. Formatting it nicely does not introduce maintenence concerns, it's paying technical debt introduced from people treating it like it's a program instead of doc. Anyone who is looking at the doc while they're editing it will definitely notice. |
Reviewed by: mhorne MFC after: 3 days Pull Request: freebsd#1456
I'm not saying that presentation is meaningless; I'm just much more pessimistic about people looking at the docs when they edit it. But that's beside the point of whether a script would be useful. Let's put it this way: suppose that it takes you 5 minutes on average to align the lists on each man page. That's 5 minutes to look the page, decide on the appropriate indentation(s), make any edits, do a git commit, and create a new PR. Given 4000 man pages, that's 333 hours of effort. (If you think that 5 minutes per file is too short, then it's even more hours!) By contrast, suppose that we spent 5 hours working on a script which would align the lists automatically. Huge time saving! (And if anybody edited a man page without regard for the alignment, no worries: just run the script again to fix it.) I'm happy to work on the python side of things. Where my interest wanes is:
|
Align lists to polish the presentation of the document. Tested with
MANWIDTH=80
andMANWIDTH=59
. We loose a line at 80 and gain a line at 59.Cc @mhorne, @gperciva