-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(unsure) development.7: add files #1274
Conversation
.It Pa src/CONTRIBUTING.md | ||
.Fx | ||
contribution guidelines | ||
.It Pa src/tools/tools/git/HOWTO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should not link to this, it is stale. If desired we could extract useful content into somewhere less hidden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rationale: doc and ports trees don't accept gihub PRs. I had patches sitting in there for months, but then when I discovered how to put them on phabricator, the discussions began immediately. Then from there, git-arc(1) took me even longer to discover and is actually cozy.
I'm open to any suggestions how to solve this problem in a better way, but that was the problem I'm trying to solve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but the arcgit
tool described in the HOWTO
is something older and separate from git-arc
, but with similar functionality. It is a step backwards to start advertising it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea. I'd delete that file even i think and put everything in contributing.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id keep contributing. Sorry if that wasn't clear. Just the howto file that's a problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to mention git-arc. Is it more appropriate:
- Files: git-arc.sh
- Files: git-arc.1
- See also: /path/git-arc.1
Using quoted literals is a mistake in roff(7). Please escape with `\&`, the zero-width-space. MFC after: 3 days
MFC after: 3 days
c7749f8
to
e22ece0
Compare
Is this the right place for this information?
Should git-arc(1) be massaged into the paragraph about reviews.freebsd.org instead of being mentioned here?
Am I looking at this problem from the wrong angle entirely?
Edit: I intend to massage github into this at some point.