Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdconfig: don't print NUL in the options list #1268

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

asomers
Copy link
Member

@asomers asomers commented May 31, 2024

MFC with: b01988d
Sponsored by: Axcient

@asomers asomers requested a review from bsdimp May 31, 2024 21:15
@asomers
Copy link
Member Author

asomers commented May 31, 2024

cc @ricardobranco777

@asomers
Copy link
Member Author

asomers commented May 31, 2024

Currently if there aren't any options nothing will be printed. The line will end with a tab character. Do you think we should print - to be consistent with the other columns?

Copy link
Contributor

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Fixes:	b01988d
Sponsored by: Axcient
Reviewed by: imp, Ricardo Branco
Pull Request: freebsd#1268
@bsdimp
Copy link
Member

bsdimp commented Jun 1, 2024

Landing with a slightly tweaked commit message (Fixes: instead of MFC With:). I'm doing a quick buildworld before landing, but it passes all my eyeball tests.

@freebsd-git freebsd-git merged commit 4b72bab into freebsd:main Jun 1, 2024
7 of 9 checks passed
@asomers asomers deleted the mdconfig-options branch June 1, 2024 16:32
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Sep 4, 2024
Fixes:	b01988d
Sponsored by: Axcient
Reviewed by: imp, Ricardo Branco
Pull Request: freebsd/freebsd-src#1268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants