Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace pkg_add -r with pkg install #284

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chrislongros
Copy link
Contributor

No description provided.

@@ -175,7 +175,7 @@ endif::[]

[source,shell]
....
# pkg_add -r opera
# pkg install opera
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opera does not exist. Instead, maybe linux-opera

https://www.freshports.org/www/linux-opera/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the handbook says replace opera with linux-opera in the following paragraph

@@ -340,7 +340,7 @@ endif::[]

[source,shell]
....
# pkg_add -r koffice-kde4
# pkg install koffice-kde4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no longer any port with koffice in its name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -408,7 +408,7 @@ endif::[]

[source,shell]
....
# pkg_add -r openoffice.org
# pkg install openoffice.org
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing ports include:

editors/openoffice-4
editors/openoffice-devel
textproc/p5-OpenOffice-OODoc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editors/libreoffice is probably the better maintained of the two forks

@@ -610,7 +610,7 @@ endif::[]

[source,shell]
....
# pkg_add -r gqview
# pkg install gqview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This port was removed a few years ago,

https://www.freshports.org/graphics/gqview/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -724,7 +724,7 @@ endif::[]

[source,shell]
....
# pkg_add -r kmymoney2
# pkg install kmymoney2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This port died around two decades ago,

https://www.freshports.org/deskutils/kmymoney2/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe gnucash could be an acceptable alternative?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, if we drop the 2, we're right there where we need to be: https://www.freshports.org/finance/kmymoney/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grahamperrin

This comment was marked as resolved.

@chrislongros
Copy link
Contributor Author

chrislongros commented Oct 17, 2023

I will review the content again as soon as possible :)
Thanks for the suggestions

@chrislongros
Copy link
Contributor Author

chrislongros commented Oct 18, 2023

The content is so outdated that I am afraid it needs to be re-written again from scratch

Comment on lines 61 to 63
* Εφαρμογές γραφείου (όπως KOffice, AbiWord, The GIMP, OpenOffice.org, LibreOffice)
* Προγράμματα προβολής εγγράφων (όπως Acrobat Reader(R), gv, Xpdf, GQview)
* Χρηματοοικονομικές εφαρμογές (όπως GnuCash, Gnumeric, Abacus)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notable:


As your PR is entitled replace pkg_add -r with pkg install, the observations above are out of scope.

Re: https://wiki.freebsd.org/GitHub, for the src tree it's true that the scope of a pull request should not change during review.

If the same is true for PRs for the doc tree, then you should probably mark this comment as resolved; and then someone (not necessarily you) can progress these additional points.

HTH (hope that helps)
Graham

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrislongros sorry, I did not see your #284 until after this comment.

@dbaio
Copy link
Member

dbaio commented Feb 24, 2024

The content is so outdated that I am afraid it needs to be re-written again from scratch

Yeah, probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants