Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status: 2023q3: mfsBSD: corrections, suggestions #257

Closed
wants to merge 2 commits into from

Conversation

grahamperrin
Copy link
Contributor

@grahamperrin grahamperrin commented Sep 17, 2023

Fix markup for hard line breaks.

https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#paragraphs

Matuška (not Matuska).

For a named person – with no visible hint of a mailto: URL – reference to their home page may be less surprising than launch of an email application.

Whilst here: other minor changes (suggestions).


As this relates to a status report, please treat it as an exception to the rule that excludes my PRs from this repository. Thank you.

@grahamperrin
Copy link
Contributor Author

@soobinrho and reviewers

Re: #252 (comment) I am to blame for the incorrect markup. Sorry.

I realised the mistake at my http://localhost:1313/status/report-2023-07-2023-09/mfsbsd/ view of d5f71f6, here's a PDF:

Corrected, and with suggested changes:

I am uncertain about some suggestions, so do (please) comment if there is wrongness.

Home page for Martin Matuška

The 2009 white paper gave the mfsBSD home page as http://people.freebsd.org/~mm/mfsbsd/, which redirects to https://mfsbsd.vx.sk/ where @mmatuska offers http://blog.vx.sk/?user_language=en for his blog. https://github.com/mmatuska/ more concisely refers to:

  • http://blog.vx.sk/

@grahamperrin grahamperrin marked this pull request as ready for review September 17, 2023 10:48
Copy link
Contributor

@soobinrho soobinrho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍👍

Fix incorrect markup for hard line breaks.  Blame: mine.

https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#paragraphs

Matuška (truer than Matuska).

For a named person – with no visible hint of a mailto: URL – reference to their
home page may be less surprising than launch of an email application.

Whilst here: other minor changes (suggestions).

Fixes: d5f71f6 Status/2023Q3/mfsbsd.adoc: Add report
Pull-request:	freebsd#257
Closes:		freebsd#257
Signed-off-by:  Graham Perrin <[email protected]>
@grahamperrin
Copy link
Contributor Author

@soobinrho, thank you.


Reviewers, please excuse the force-push. I know, it is (or was) discouraged. My force in cases such as this is to add pull request, closure, and sign-off lines for .patch file purposes.

Here: https://github.com/freebsd/freebsd-doc/pull/257.patch

Copy link
Member

@lsalvadore lsalvadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once the e-mail address is restored.

freebsd-git pushed a commit that referenced this pull request Sep 28, 2023
Approved by:	soobinrho (report author)
Pull Request:	#257
@lsalvadore
Copy link
Member

Merged, thanks.

@lsalvadore lsalvadore closed this Sep 28, 2023
@grahamperrin grahamperrin deleted the grahamperrin-mfsbsd branch September 29, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants